Skip to content

Return proper exit code on ssh with TTY #3192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 27, 2022
Merged

Return proper exit code on ssh with TTY #3192

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b60d811
Return proper exit code on ssh with TTY
spikecurtis Jul 25, 2022
ca93544
Fix Windows tests
spikecurtis Jul 27, 2022
c378faa
Fix windows tests
spikecurtis Jul 27, 2022
ee781bd
Check for nonzero exit code on kill
spikecurtis Jul 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix Windows tests 
Signed-off-by: Spike Curtis <spike@coder.com>
  • Loading branch information
@spikecurtis
spikecurtis committed Jul 27, 2022
commit ca93544ec7cf76b0bb521d08a625e31bb34f406d
4 changes: 2 additions & 2 deletions pty/start_windows_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,13 @@ func TestStart(t *testing.T) {
})
t.Run("Resize", func(t *testing.T) {
t.Parallel()
pty := ptytest.Start(t, exec.Command("cmd.exe"))
pty, _ := ptytest.Start(t, exec.Command("cmd.exe"))
err := pty.Resize(100, 50)
require.NoError(t, err)
})
t.Run("Kill", func(t *testing.T) {
t.Parallel()
pty := ptytest.Start(t, exec.Command("cmd.exe"))
pty, ps := ptytest.Start(t, exec.Command("cmd.exe"))
err := ps.Kill()
assert.NoError(t, err)
err = ps.Wait()
Expand Down