fix: Fix dangling references in provisioner/terraform/testdata #3193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm guessing that we can't run |
That would be nice, and I can think of a couple of different ways we could approach it:
One of those (or something similar) is probably worth doing, but not super urgent IMO, since these tests don't change very frequently. There's also the concern of slowing down our CI runs. In my dev environment, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent PR (#3150) updated several of the Terraform test data files in
provisioner/terraform/testdatato rename agent resources fromdevtomain. However, some references to those resources were still using the old names, causing the Terraform modules to fail to compile. This wasn't caught in CI because the test suite is still using plan/state files that were generated before the change.This PR fixes those references, regenerates the Terraform plan/state output files so that they match the .tf files they're derived from (using
provisioner/terraform/testdata/generate.sh), and updates the Go test cases to expect the new names.The changes to the generated .tfplan/.tfstate files are a bit verbose, but they consist entirely of:
devtomainterraform-provider-coderversion in the state from 1.2.2 to 1.2.5