Skip to content

feat: Make settings page responsive #3228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 26, 2022
Merged

feat: Make settings page responsive #3228

merged 2 commits into from
Jul 26, 2022

Conversation

BrunoQuaresma
Copy link
Collaborator

Screen Shot 2022-07-26 at 16 29 08

Screen Shot 2022-07-26 at 16 29 00

Related to #3185

@BrunoQuaresma BrunoQuaresma requested a review from a team as a code owner July 26, 2022 19:31
@BrunoQuaresma BrunoQuaresma self-assigned this Jul 26, 2022
presleyp
presleyp approved these changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@presleyp presleyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really nice!

@BrunoQuaresma BrunoQuaresma enabled auto-merge (squash) July 26, 2022 19:48
@BrunoQuaresma BrunoQuaresma merged commit 991b4f7 into main Jul 26, 2022
@BrunoQuaresma BrunoQuaresma deleted the bq/make-settings-responsive branch July 26, 2022 19:48
@AbhineetJain
Copy link
Contributor

I believe we can add a story for the reduced viewport if it does not exist.

@BrunoQuaresma
Copy link
Collaborator Author

I agree! I will make it next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@presleyp presleyp presleyp approved these changes

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BrunoQuaresma @AbhineetJain @presleyp