fix: error messages from workspaceScheduleXService #3255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhineetJain
approved these changes
Jul 28, 2022
| @@ -49,7 +51,7 @@ export const getFormHelpers = | |||
| export const getFormHelpersWithError = <T>( | |||
| form: FormikContextType<T>, | |||
| error?: Error | unknown, | |||
| ): ((name: keyof T, HelperText?: ReactNode) => FormHelpers) => { | |||
| ): ((name: keyof T, HelperText?: ReactNode, errorName?: string) => FormHelpers) => { | |||
There was a problem hiding this comment.
nit: Instead of ‘errorName’, we can call the argument field ‘fieldName’ or ‘backendFieldName’.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of #3097
ttl_msbut the frontend displays TTL in hours so it doesn't use the same name).Testing
Given I enter a number greater than my template allows (24 for coder-ts),
When I click Submit
Then I see an error message at the top of the page and a more specific message under the Time Until Shutdown field
(note that if the frontend validation is fixed by the time this is tested, there will only be a message under the field)