Skip to content

fix: remove string TTL from workspace error responses #3257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 27, 2022
Merged

fix: remove string TTL from workspace error responses #3257

merged 4 commits into from
Jul 27, 2022

Conversation

johnstcn
Copy link
Member

This PR:

  • Rewrites some error messages to better integrate with the frontend (ttl_ms -> time until shutdown)
  • Makes codersdk.ValidationError implement the error interface
  • only return validations if the error was a validation error, return detail otherwise (e.g. database error)

@johnstcn johnstcn self-assigned this Jul 27, 2022
presleyp
presleyp approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@presleyp presleyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

@johnstcn johnstcn enabled auto-merge (squash) July 27, 2022 21:06
@johnstcn johnstcn requested a review from a team as a code owner July 27, 2022 21:11
presleyp
presleyp approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@presleyp presleyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

frontend ✅

AbhineetJain
AbhineetJain approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@AbhineetJain AbhineetJain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice!

@johnstcn johnstcn merged commit 27ea415 into main Jul 27, 2022
@johnstcn johnstcn deleted the cj/noissue/nuke-ttl-from-errors branch July 27, 2022 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emyrk Emyrk Emyrk approved these changes

+2 more reviewers

@presleyp presleyp presleyp approved these changes

@AbhineetJain AbhineetJain AbhineetJain approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@johnstcn @presleyp @Emyrk @AbhineetJain