Skip to content

chore: Remove line numbers from auto-gen typescript #3258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 27, 2022

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Jul 27, 2022

The line numbers are just extra noise that change when things shift
around. They are not required and usually make CI fail when you
forget to run 'make gen'.

The line numbers are just extra noise that change when things shift
around. They are not required and usually make CI fail when you
forget to run 'make gen'.
@Emyrk Emyrk requested a review from a team as a code owner July 27, 2022 21:17
@Emyrk Emyrk requested review from johnstcn and presleyp July 27, 2022 21:19
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

Copy link
Contributor

@presleyp presleyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@Emyrk Emyrk enabled auto-merge (squash) July 27, 2022 21:31
@Emyrk Emyrk merged commit 6230d55 into main Jul 27, 2022
@Emyrk Emyrk deleted the stevenmasley/drop_line_numbers branch July 27, 2022 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants