fix: Workspace schedule button on responsive #3264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
presleyp
reviewed
Jul 28, 2022
| export const SmallViewport = Template.bind({}) | ||
| SmallViewport.args = WorkspaceOffShort.args | ||
| SmallViewport.parameters = { | ||
| chromatic: { viewports: [320] }, |
There was a problem hiding this comment.
This looks useful, how does it work?
There was a problem hiding this comment.
We basically are saying to chromatic to test this snapshot using the 320px viewport. Unfortunately, looks like a Chromatic thing not a Storybook native option.
There was a problem hiding this comment.
Looks like maybe Chromatic isn't registering this one?
presleyp
approved these changes
Jul 28, 2022
Kira-Pilot
approved these changes
Jul 28, 2022
AbhineetJain
approved these changes
Jul 28, 2022
site/src/components/WorkspaceScheduleButton/WorkspaceScheduleButton.stories.tsx
Outdated
Show resolved
Hide resolved
…utton.stories.tsx Co-authored-by: Abhineet Jain <AbhineetJain@users.noreply.github.com>
|
Fixes #3267 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After:
With + and - buttons:
Before:
