Skip to content

fix: handle getUser error #3285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 29, 2022
Merged

fix: handle getUser error #3285

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fbd0c6d
fix: handle getUser error
AbhineetJain Jul 29, 2022
8dcd958
change language to use sign-out
AbhineetJain Jul 29, 2022
52c23fb
update sign out message
AbhineetJain Jul 29, 2022
ade96de
update internal error message
AbhineetJain Jul 29, 2022
da9c675
Merge branch 'main' into abhineetjain/handle-get-user-error
AbhineetJain Jul 29, 2022
4bcf5e7
simplify conditional
AbhineetJain Jul 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
simplify conditional
  • Loading branch information
@AbhineetJain
AbhineetJain committed Jul 29, 2022
commit 4bcf5e722249d1072379bf99ba3dfecb667e6950
2 changes: 1 addition & 1 deletion site/src/pages/LoginPage/LoginPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export const LoginPage: React.FC = () => {
const isLoading = authState.hasTag("loading")
const redirectTo = retrieveRedirect(location.search)
const locationState = location.state ? (location.state as LocationState) : null
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to use a ternary because of types? Or can we:

Suggested change
const locationState = location.state ? (location.state as LocationState) : null
const locationState = location.state ?? null

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

location.state can be null, but since we are typecasting it, the compiler thinks it is never null, so we are typecasting it only if it is not null.

const isRedirected = locationState !== null ? locationState.isRedirect : false
const isRedirected = locationState ? locationState.isRedirect : false

const onSubmit = async ({ email, password }: { email: string; password: string }) => {
authSend({ type: "SIGN_IN", email, password })
Expand Down