Skip to content

fix: Update CLI Placeholder color to have a dark theme alternative #3294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2022

Conversation

Mainstay-Noah-Huppert
Copy link
Contributor

@Mainstay-Noah-Huppert Mainstay-Noah-Huppert commented Jul 29, 2022

Fixes #3293

The light color is still ANSI 256 color 240, but in hex code.

image

image

Up to y'all regarding if this is the right color. Not sure if this meets any branding Coder might have, but I tried picking something sort of similar to the ascent colors on the website.

@Mainstay-Noah-Huppert Mainstay-Noah-Huppert marked this pull request as ready for review July 29, 2022 14:41
@Mainstay-Noah-Huppert Mainstay-Noah-Huppert changed the title 3293, cli: Updated Placeholder color to have a dark theme alt 3293, cli: Updated Placeholder color to have a dark theme alternative Jul 29, 2022
@ammario ammario requested a review from kylecarbs July 29, 2022 17:44
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like an improvement to me! Approved 🥳

@kylecarbs kylecarbs changed the title 3293, cli: Updated Placeholder color to have a dark theme alternative fix: Update CLI Placeholder color to have a dark theme alternative Jul 29, 2022
@kylecarbs
Copy link
Member

@Mainstay-Noah-Huppert I also updated the title to conform to our format!

@catvec
Copy link

catvec commented Jul 30, 2022

@Mainstay-Noah-Huppert I also updated the title to conform to our format!

Thank youuuu

@kylecarbs kylecarbs merged commit 16f0f1a into coder:main Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants