Skip to content

ci: revert skips of required checks #3303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 1 addition & 44 deletions .github/workflows/coder.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ jobs:
runs-on: ubuntu-latest
outputs:
docs-only: ${{ steps.filter.outputs.docs_count == steps.filter.outputs.all_count }}
go: ${{ steps.filter.outputs.go }}
sh: ${{ steps.filter.outputs.sh }}
steps:
- uses: actions/checkout@v3
Expand All @@ -49,10 +48,6 @@ jobs:
- 'docs/**'
# For testing:
# - '.github/**'
go:
- "**.go"
- "**.mod"
- "**.sum"
sh:
- "**.sh"
- id: debug
Expand All @@ -63,36 +58,15 @@ jobs:
debug-inputs:
needs:
- changes
- pr-context
runs-on: ubuntu-latest
steps:
- id: log
run: |
echo "${{ toJSON(needs) }}"
echo "${{ contains(needs.pr-context.outputs.skips, 'test/go/postgres') }} "
echo "${{ contains(needs.pr-context.outputs.skips, 'test/e2e') }} "

pr-context:
runs-on: ubuntu-latest
outputs:
skips: ${{ steps.pr-context.outputs.skips }}
steps:
- uses: actions/checkout@v3
- uses: actions/setup-go@v3
with:
go-version: "~1.18"
- id: pr-context
env:
GITHUB_CONTEXT: ${{ toJSON(github) }}
run: |
(cd .github/workflows/prcontext && go build)
./.github/workflows/prcontext/prcontext

style-lint-golangci:
name: style/lint/golangci
timeout-minutes: 5
needs: changes
if: needs.changes.outputs.go == 'true'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
Expand All @@ -108,8 +82,6 @@ jobs:
name: style/lint/shellcheck
timeout-minutes: 5
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.sh == 'true'
steps:
- uses: actions/checkout@v3
- name: Run ShellCheck
Expand All @@ -122,8 +94,6 @@ jobs:
style-lint-typescript:
name: "style/lint/typescript"
timeout-minutes: 5
needs: changes
if: needs.changes.outputs.docs-only == 'false'
runs-on: ubuntu-latest
steps:
- name: Checkout
Expand Down Expand Up @@ -207,8 +177,6 @@ jobs:

style-fmt:
name: "style/fmt"
needs: changes
if: needs.changes.outputs.docs-only == 'false'
runs-on: ubuntu-latest
timeout-minutes: 5
steps:
Expand Down Expand Up @@ -241,8 +209,6 @@ jobs:

test-go:
name: "test/go"
needs: changes
if: needs.changes.outputs.docs-only == 'false'
runs-on: ${{ matrix.os }}
timeout-minutes: 20
strategy:
Expand Down Expand Up @@ -328,12 +294,6 @@ jobs:

test-go-postgres:
name: "test/go/postgres"
needs:
- changes
- pr-context
if: >
needs.changes.outputs.docs-only == 'false' &&
!contains(needs.pr-context.outputs.skips, 'test/go/postgres')
runs-on: ubuntu-latest
# This timeout must be greater than the timeout set by `go test` in
# `make test-postgres` to ensure we receive a trace of running
Expand Down Expand Up @@ -514,8 +474,6 @@ jobs:

test-js:
name: "test/js"
needs: changes
if: needs.changes.outputs.docs-only == 'false'
runs-on: ubuntu-latest
timeout-minutes: 20
steps:
Expand Down Expand Up @@ -571,8 +529,7 @@ jobs:
name: "test/e2e/${{ matrix.os }}"
needs:
- changes
- pr-context
if: needs.changes.outputs.docs-only == 'false' && !contains(needs.pr-context.outputs.skips, 'test/e2e')
if: needs.changes.outputs.docs-only == 'false'
runs-on: ${{ matrix.os }}
timeout-minutes: 20
strategy:
Expand Down
7 changes: 0 additions & 7 deletions .github/workflows/prcontext/README.md

This file was deleted.

12 changes: 0 additions & 12 deletions .github/workflows/prcontext/go.mod

This file was deleted.

16 changes: 0 additions & 16 deletions .github/workflows/prcontext/go.sum

This file was deleted.

39 changes: 0 additions & 39 deletions .github/workflows/prcontext/main.go

This file was deleted.

28 changes: 0 additions & 28 deletions .github/workflows/prcontext/parse.go

This file was deleted.

38 changes: 0 additions & 38 deletions .github/workflows/prcontext/parse_test.go

This file was deleted.