Skip to content

fix: chromatic workflow filter #3352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2022
Merged

fix: chromatic workflow filter #3352

merged 1 commit into from
Aug 2, 2022

Conversation

AbhineetJain
Copy link
Contributor

This PR fixes the workflow filter for checking when to run the Chromatic job. Currently, the Chromatic job is being skipped even for TypeScript changes.

@AbhineetJain AbhineetJain requested a review from ammario August 2, 2022 05:55
@AbhineetJain
Copy link
Contributor Author

AbhineetJain commented Aug 2, 2022 •
edited
Loading

Merged this branch into #3341 and #3346 to confirm that the change works.

@AbhineetJain AbhineetJain requested a review from a team August 2, 2022 05:58
@AbhineetJain AbhineetJain merged commit 5ae19f0 into main Aug 2, 2022
@AbhineetJain AbhineetJain deleted the abhineetjain/fix-chromatic-workflow branch August 2, 2022 08:23
@Kira-Pilot
Copy link
Member

Late to the game, but thank you!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ammario ammario ammario approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AbhineetJain @Kira-Pilot @ammario