fix: Improve shutdown procedure of ssh, portforward, wgtunnel cmds #3354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We could turn it into a practice to wrap `cmd.Context()` so that we have more fine-grained control of cancellation. Sometimes in tests we may be running commands with a context that is never canceled. Related to #3221
mafredri
commented
Aug 2, 2022
| @@ -224,13 +236,17 @@ func ssh() *cobra.Command { | |||
|
|
|||
| sshSession.Stdin = cmd.InOrStdin() | |||
| sshSession.Stdout = cmd.OutOrStdout() | |||
| sshSession.Stderr = cmd.OutOrStdout() | |||
| sshSession.Stderr = cmd.ErrOrStderr() | |||
There was a problem hiding this comment.
This is a drive-by change I did. It seemed wrong but perhaps I didn't understand the purpose?
kylecarbs
approved these changes
Aug 2, 2022
We're still inheriting it, so in that sense we're still using it. I think this change can make more sense if we consider other scenarios, like adding tracing to the commands. We'd want to ensure that the context we're passing along contains the tracing information which means we shouldn't be accessing the command context directly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could turn it into a practice to wrap
cmd.Context()so that we havemore fine-grained control of cancellation. Sometimes in tests we may be
running commands with a context that is never canceled.
Related to #3221