Skip to content

feat: Add switches for auto-start and auto-stop #3358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Aug 10, 2022
Merged

feat: Add switches for auto-start and auto-stop #3358

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
54bf130
Add elements
presleyp Jul 29, 2022
ecc1137
Add Loading story
presleyp Jul 29, 2022
6705076
Make form show empty values when manual
presleyp Jul 29, 2022
91259c4
Make form depend on switches
presleyp Aug 1, 2022
70228bd
Fix style
presleyp Aug 1, 2022
52b26bf
Format
presleyp Aug 1, 2022
b224258
Update unit tests
presleyp Aug 1, 2022
4f68bb1
Tweaks
presleyp Aug 1, 2022
ff48adf
Update storybook
presleyp Aug 2, 2022
bbaee7d
Move util files
presleyp Aug 8, 2022
f251efa
Pull out more util functions
presleyp Aug 8, 2022
eab6e5f
Pull out strings
presleyp Aug 8, 2022
e92a2c1
Add border to section
presleyp Aug 8, 2022
a35bf20
Make min ttl 1
presleyp Aug 8, 2022
750f08b
Format
presleyp Aug 8, 2022
3dfa41b
Fix import
presleyp Aug 8, 2022
848732a
Fix validation for falsey values
presleyp Aug 8, 2022
bfbabe1
Format and fix tests
presleyp Aug 9, 2022
d1420de
Put switches in form, persist form state
presleyp Aug 10, 2022
0577ea9
Fix bug
presleyp Aug 10, 2022
a6271ca
Remove helper text when disabled
presleyp Aug 10, 2022
af4e8e4
Fix storybook
presleyp Aug 10, 2022
e8ae5ba
Revert "Remove helper text when disabled"
presleyp Aug 10, 2022
4993c3d
Format
presleyp Aug 10, 2022
a17dc2e
Use nicer function to set values
presleyp Aug 10, 2022
bf22caa
Format
presleyp Aug 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix storybook
  • Loading branch information
@presleyp
presleyp committed Aug 10, 2022
commit af4e8e460a74a7622f66a07dc7b681c8b7dea57f
46 changes: 25 additions & 21 deletions site/src/components/WorkspaceScheduleForm/WorkspaceScheduleForm.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import advancedFormat from "dayjs/plugin/advancedFormat"
import timezone from "dayjs/plugin/timezone"
import utc from "dayjs/plugin/utc"
import { defaultSchedule, emptySchedule } from "pages/WorkspaceSchedulePage/schedule"
import { emptyTTL } from "pages/WorkspaceSchedulePage/ttl"
import { defaultTTL, emptyTTL } from "pages/WorkspaceSchedulePage/ttl"
import { makeMockApiError } from "testHelpers/entities"
import { WorkspaceScheduleForm, WorkspaceScheduleFormProps } from "./WorkspaceScheduleForm"

Expand All @@ -22,51 +22,56 @@ export default {
onSubmit: {
action: "onSubmit",
},
toggleAutoStart: {
action: "toggleAutoStart",
},
toggleAutoStop: {
action: "toggleAutoStop",
},
},
}

const Template: Story<WorkspaceScheduleFormProps> = (args) => <WorkspaceScheduleForm {...args} />

const defaultInitialValues = {
autoStartEnabled: true,
...defaultSchedule(),
autoStopEnabled: true,
ttl: defaultTTL
}

export const AllDisabled = Template.bind({})
AllDisabled.args = {
autoStart: { enabled: false, schedule: emptySchedule },
autoStop: { enabled: false, ttl: emptyTTL },
initialValues: {
autoStartEnabled: false,
...emptySchedule,
autoStopEnabled: false,
ttl: emptyTTL
}
}

export const AutoStart = Template.bind({})
AutoStart.args = {
autoStart: { enabled: true, schedule: defaultSchedule() },
autoStop: { enabled: false, ttl: emptyTTL },
initialValues: {
autoStartEnabled: true,
...defaultSchedule(),
autoStopEnabled: false,
ttl: emptyTTL
},
}

export const WorkspaceWillShutdownInTwoHours = Template.bind({})
WorkspaceWillShutdownInTwoHours.args = {
autoStart: { enabled: true, schedule: defaultSchedule() },
autoStop: { enabled: true, ttl: 2 },
initialValues: { ...defaultInitialValues, ttl: 2 }
}

export const WorkspaceWillShutdownInADay = Template.bind({})
WorkspaceWillShutdownInADay.args = {
autoStart: { enabled: true, schedule: defaultSchedule() },
autoStop: { enabled: true, ttl: 24 },
initialValues: { ...defaultInitialValues, ttl: 24 }
}

export const WorkspaceWillShutdownInTwoDays = Template.bind({})
WorkspaceWillShutdownInTwoDays.args = {
autoStart: { enabled: true, schedule: defaultSchedule() },
autoStop: { enabled: true, ttl: 48 },
initialValues: { ...defaultInitialValues, ttl: 48 }
}

export const WithError = Template.bind({})
WithError.args = {
autoStart: { enabled: false, schedule: emptySchedule },
autoStop: { enabled: true, ttl: 100 },
initialValues: { ...defaultInitialValues, ttl: 100 },
initialTouched: { ttl: true },
submitScheduleError: makeMockApiError({
message: "Something went wrong.",
Expand All @@ -76,7 +81,6 @@ WithError.args = {

export const Loading = Template.bind({})
Loading.args = {
autoStart: { enabled: true, schedule: defaultSchedule() },
autoStop: { enabled: true, ttl: 2 },
initialValues: defaultInitialValues,
isLoading: true,
}