Skip to content

chore: use consistent button type for settings #3362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 4, 2022
Merged

chore: use consistent button type for settings #3362

merged 1 commit into from
Aug 4, 2022

Conversation

bpmct
Copy link
Member

@bpmct bpmct commented Aug 3, 2022

Fixes #2374

@bpmct bpmct requested a review from AbhineetJain August 3, 2022 03:09
@bpmct bpmct requested a review from a team as a code owner August 3, 2022 03:09
@bpmct bpmct self-assigned this Aug 3, 2022
Kira-Pilot
Kira-Pilot approved these changes Aug 3, 2022
View reviewed changes
Copy link
Member

@Kira-Pilot Kira-Pilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@bpmct bpmct merged commit 075454c into main Aug 4, 2022
@bpmct bpmct deleted the bpmct/consistent-settings branch August 4, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

@AbhineetJain AbhineetJain AbhineetJain approved these changes

@Kira-Pilot Kira-Pilot Kira-Pilot approved these changes

Assignees

@bpmct bpmct

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consistent CTA design on the Settings page
4 participants
@bpmct @kylecarbs @AbhineetJain @Kira-Pilot