Skip to content

chore: alphabetize template list #3363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 5, 2022
Merged

chore: alphabetize template list #3363

merged 2 commits into from
Aug 5, 2022

Conversation

bpmct
Copy link
Member

@bpmct bpmct commented Aug 3, 2022

fixes #2836

@bpmct bpmct self-assigned this Aug 3, 2022
kylecarbs
kylecarbs approved these changes Aug 3, 2022
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mafredri
mafredri approved these changes Aug 3, 2022
View reviewed changes
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A sensible change considering the client can't request different ordering.

Test failures need addressing but otherwise good to go. 👍🏻

@bpmct bpmct requested a review from dwahler August 4, 2022 16:29
dwahler
dwahler approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@dwahler dwahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

mafredri
mafredri approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@bpmct bpmct merged commit f14efd1 into main Aug 5, 2022
@bpmct bpmct deleted the bpmct/fix-template-order branch August 5, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mafredri mafredri mafredri approved these changes

@kylecarbs kylecarbs kylecarbs approved these changes

+1 more reviewer

@dwahler dwahler dwahler approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@bpmct bpmct

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Template lists should be alphabetical
4 participants
@bpmct @mafredri @dwahler @kylecarbs