fix: Enable goleak for cli tests
#3370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
added a commit
that referenced
this pull request
Aug 10, 2022
kylecarbs
approved these changes
Aug 12, 2022
| goleak.VerifyTestMain(m, | ||
| // The lumberjack library is used by by agent and seems to leave | ||
| // goroutines after Close(), fails TestGitSSH tests. | ||
| // https://github.com/natefinch/lumberjack/pull/100 |
There was a problem hiding this comment.
Should we do a go mod replace instead?
There was a problem hiding this comment.
TBH I haven't done a proper review of that PR, and I'm not confident in using it in a production environment without doing so. My judgement was that this is a non-issue in a production environment since the agent only runs once and thus won't be leaking memory, so I think the goleak ignore is acceptable here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables
goleakchecking forclicommands. This should be worhwile to detect potential leaks caused by long-running commands likecoder server, maybe others.Merging is currently blocked until these PRs are merged (or we switch to forks):
Readcancellation onClosepion/udp#73Closes #3221