Skip to content

fix: Move state pull output to stdout #3382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 4, 2022
Merged

fix: Move state pull output to stdout #3382

merged 2 commits into from
Aug 4, 2022

Conversation

kylecarbs
Copy link
Member

Fixes #1645.

@kylecarbs kylecarbs requested a review from mafredri August 4, 2022 13:34
@kylecarbs kylecarbs self-assigned this Aug 4, 2022
mafredri
mafredri approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I did not realize cmd.Print goes to stderr, LGTM!

AbhineetJain
AbhineetJain reviewed Aug 4, 2022
View reviewed changes
@kylecarbs @AbhineetJain
Update cli/state.go
b04770c 
Co-authored-by: Abhineet Jain <AbhineetJain@users.noreply.github.com>
@kylecarbs kylecarbs enabled auto-merge (squash) August 4, 2022 15:10
@kylecarbs kylecarbs merged commit ad20b23 into main Aug 4, 2022
@kylecarbs kylecarbs deleted the fixout branch August 4, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mafredri mafredri mafredri approved these changes

+1 more reviewer

@AbhineetJain AbhineetJain AbhineetJain left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

coder state pull emits to stderr instead of stdout
3 participants
@kylecarbs @mafredri @AbhineetJain