Skip to content

fix: Add ps.Kill/Wait to test cleanup in ptytest.Start #3387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2022
Merged

fix: Add ps.Kill/Wait to test cleanup in ptytest.Start #3387

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: Add ps.Kill/Wait to test cleanup in ptytest.Start
  • Loading branch information
@mafredri
mafredri committed Aug 5, 2022
commit 443b222025977485deb6a4fe6a042bda46a523c5
4 changes: 4 additions & 0 deletions pty/ptytest/ptytest.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@ func Start(t *testing.T, cmd *exec.Cmd) (*PTY, pty.Process) {

ptty, ps, err := pty.Start(cmd)
require.NoError(t, err)
t.Cleanup(func() {
_ = ps.Kill()
_ = ps.Wait()
})
return create(t, ptty, cmd.Args[0]), ps
}

Expand Down