Skip to content

chore: post-hoc testutil fix #3391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2022
Merged

chore: post-hoc testutil fix #3391

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: post-hoc testutil fix
  • Loading branch information
@johnstcn
johnstcn committed Aug 5, 2022
commit 7bef7ae20c92488b47a197bc8d8abb93af54a7dd
4 changes: 3 additions & 1 deletion testutil/eventually.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,9 @@ func Eventually(ctx context.Context, t testing.TB, condition func(context.Contex
assert.NoError(t, ctx.Err(), "Eventually timed out")
return false
case <-tick:
assert.NoError(t, ctx.Err(), "Eventually timed out")
if !assert.NoError(t, ctx.Err(), "Eventually timed out") {
return false
}
if condition(ctx) {
return true
}
Expand Down