Skip to content

chore: Fix golangci-lint configuration and patch errors #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 20, 2022
Merged

chore: Fix golangci-lint configuration and patch errors #34

merged 5 commits into from
Jan 20, 2022

Conversation

kylecarbs
Copy link
Member

Due to misconfiguration of a linting rules directory, our linter has not been
working properly. This change fixes the configuration issue, and all remaining
linting errors.

@kylecarbs
chore: Fix golangci-lint configuration and patch errors
1e62837 
Due to misconfiguration of a linting rules directory, our linter has not been
working properly. This change fixes the configuration issue, and all remaining
linting errors.
@kylecarbs kylecarbs self-assigned this Jan 20, 2022
@codecov
Copy link

codecov bot commented Jan 20, 2022 •
edited
Loading

Codecov Report

Merging #34 (3ca4a35) into main (6a919ae) will increase coverage by 5.04%.
The diff coverage is 69.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
+ Coverage   65.33%   70.37%   +5.04%     
==========================================
  Files          19       48      +29     
  Lines         150     2167    +2017     
  Branches        9        9              
==========================================
+ Hits           98     1525    +1427     
- Misses         48      499     +451     
- Partials        4      143     +139
Flag Coverage Δ
unittest-go-macos-latest 66.73% <67.40%> (?)
unittest-go-ubuntu-latest 70.05% <69.23%> (?)
unittest-go-windows-latest 66.04% <66.66%> (?)
unittest-js 65.33% <ø> (ø)
Impacted Files Coverage Δ
database/db.go 0.00% <0.00%> (ø)
database/pubsub_memory.go 87.17% <0.00%> (ø)
peer/netconn.go 30.00% <0.00%> (ø)
peerbroker/listen.go 82.81% <ø> (ø)
database/postgres/postgres.go 66.66% <20.00%> (ø)
provisioner/terraform/provision.go 63.26% <50.00%> (ø)
httpapi/httpapi.go 68.11% <55.55%> (ø)
coderd/users.go 59.58% <62.50%> (ø)
coderd/userpassword/userpassword.go 63.41% <66.66%> (ø)
cryptorand/numbers.go 40.70% <66.66%> (ø)
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a919ae...3ca4a35. Read the comment docs.

bryphe-coder
bryphe-coder approved these changes Jan 20, 2022
View reviewed changes
Copy link
Contributor

@bryphe-coder bryphe-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching the lint misconfiguration and fixing these!

@kylecarbs kylecarbs merged commit 2654a93 into main Jan 20, 2022
@kylecarbs kylecarbs deleted the fixlint branch January 20, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@bryphe-coder bryphe-coder bryphe-coder approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylecarbs @bryphe-coder