Skip to content

feat: Add support for renaming workspaces #3409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Aug 26, 2022
Merged

feat: Add support for renaming workspaces #3409

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
95e95ed
feat: Implement workspace renaming
mafredri Aug 3, 2022
c8adca1
wip: Add rename command
mafredri Aug 4, 2022
3f8e780
fix: Test
mafredri Aug 8, 2022
a1da1fe
feat: Implement database.IsUniqueViolation
mafredri Aug 9, 2022
0b23095
fix: Typo
mafredri Aug 9, 2022
055d05a
chore: Refactor to allow matching on multiple constraints
mafredri Aug 9, 2022
721eb87
chore: Typos
mafredri Aug 9, 2022
9320850
fix: Properly handle deletion / affected rows
mafredri Aug 9, 2022
256b7ef
Revert "fix: Properly handle deletion / affected rows"
mafredri Aug 9, 2022
0455b67
fix: Return the updated row and handle sql.ErrNoRows
mafredri Aug 9, 2022
7ce1b3b
fix: Database fake
mafredri Aug 9, 2022
f8dcf51
fix: Add data loss warning
mafredri Aug 24, 2022
846333b
fix: Skip prompt in rename test
mafredri Aug 24, 2022
f8dad71
fix: Allow skip prompt
mafredri Aug 24, 2022
54771b8
fix: Amend PR comments
mafredri Aug 24, 2022
6b221ff
fix: Rename test
mafredri Aug 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: Database fake
  • Loading branch information
@mafredri
mafredri committed Aug 24, 2022
commit 7ce1b3bff5871cd481c5eaa77f3ca85f74c11bf3
8 changes: 4 additions & 4 deletions coderd/database/databasefake/databasefake.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2091,7 +2091,7 @@ func (q *fakeQuerier) UpdateProvisionerJobWithCompleteByID(_ context.Context, ar
return sql.ErrNoRows
}

func (q *fakeQuerier) UpdateWorkspace(_ context.Context, arg database.UpdateWorkspaceParams) error {
func (q *fakeQuerier) UpdateWorkspace(_ context.Context, arg database.UpdateWorkspaceParams) (database.Workspace, error) {
q.mutex.Lock()
defer q.mutex.Unlock()

Expand All @@ -2104,17 +2104,17 @@ func (q *fakeQuerier) UpdateWorkspace(_ context.Context, arg database.UpdateWork
continue
}
if other.Name == arg.Name {
return &pq.Error{Code: "23505", Message: "duplicate key value violates unique constraint"}
return database.Workspace{}, &pq.Error{Code: "23505", Message: "duplicate key value violates unique constraint"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL you can just return the correct SQL error codes 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit janky 😅.. but at least the codes will never change.

}
}

workspace.Name = arg.Name
q.workspaces[i] = workspace

return nil
return workspace, nil
}

return sql.ErrNoRows
return database.Workspace{}, sql.ErrNoRows
}

func (q *fakeQuerier) UpdateWorkspaceAutostart(_ context.Context, arg database.UpdateWorkspaceAutostartParams) error {
Expand Down