feat: add audit page title, subtitle, and CLI snippet #3419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
presleyp
reviewed
Aug 8, 2022
| body: "An audit log is a record of events and changes made throughout a system.", | ||
| } | ||
|
|
||
| export const AuditHelpTooltip: FC = () => { |
There was a problem hiding this comment.
Good use of component nesting here (tooltips)
|
The small viewport story doesn't have a small viewport for me, do I need to configure anything? |
|
@presleyp hmmm, are you seeing something weird in Chromatic CI (if so, can you post a screenshot?) or do you mean you're having trouble when running locally? The Chromatic CI snapshot looks right to me. In a smaller viewport, the code block containing the CI command can be found under the page title and subtitle as opposed to across from it. |
|
I meant Chromatic CI but actually now it looks fine! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3357
We've begun to scaffold out the Audit Page. The CLI command widget may fluctuate in design down the road; right now, I just wanted to get something in there for MVP, so I'm using our existing
CodeExamplecomponent. The CLI command is a placeholder rn as we figure out what we actually want.Large Screens
Small Screens