feat: Add support for GitHub Enterprise authentication #3422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was manually tested with GitHub Enterprise v3.6.0-rc1.
bpmct
reviewed
Aug 9, 2022
| @@ -429,6 +429,39 @@ func TestServer(t *testing.T) { | |||
| cancelFunc() | |||
| <-serverErr | |||
| }) | |||
| t.Run("GitHubOAuth", func(t *testing.T) { | |||
There was a problem hiding this comment.
so this is an entirely new test for all GitHub OAuth?
There was a problem hiding this comment.
Yup! The OAuth callback code itself is tested quite extensively in the other handler, so this just ensures it enables properly, and does a correct callback URL for Enterprise.
coadler
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was manually tested with GitHub Enterprise v3.6.0-rc1.