Skip to content

fix: Reduce variables needed for Docker template #3442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 10, 2022
Merged

fix: Reduce variables needed for Docker template #3442

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6aa6928
fix: Reduce variables needed for Docker template
kylecarbs Aug 9, 2022
ed4ae7b
Fix for M2 Macbooks
Aug 10, 2022
7ba73f0
Fix name <-> id swap
kylecarbs Aug 10, 2022
915372c
Update Docker provider to remove host requirement
kylecarbs Aug 10, 2022
b9e315a
Update examples/templates/docker-with-dotfiles/main.tf
kylecarbs Aug 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix name <-> id swap
  • Loading branch information
@kylecarbs
kylecarbs committed Aug 10, 2022
commit 7ba73f02ea62a670f8fbd75a619e00863791d833
2 changes: 1 addition & 1 deletion examples/templates/docker-image-builds/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ variable "docker_image" {
}

resource "docker_volume" "home_volume" {
name = "coder-${data.coder_workspace.me.owner_id}-${lower(data.coder_workspace.me.id)}-root"
name = "coder-${data.coder_workspace.me.owner}-${lower(data.coder_workspace.me.name)}-root"
}

resource "docker_image" "coder_image" {
Expand Down
2 changes: 1 addition & 1 deletion examples/templates/docker/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ variable "docker_image" {
}

resource "docker_volume" "home_volume" {
name = "coder-${data.coder_workspace.me.owner_id}-${data.coder_workspace.me.id}-home"
name = "coder-${data.coder_workspace.me.owner}-${lower(data.coder_workspace.me.name)}-home"
}

resource "docker_container" "workspace" {
Expand Down