Skip to content

chore: Update rego to be partial execution friendly #3449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
Aug 11, 2022
Merged

chore: Update rego to be partial execution friendly #3449

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
b3536bc
chore: Update rego to be partial execution friendly
Emyrk Aug 10, 2022
75e3a12
test: Add unit test to verify partial query support
Emyrk Aug 10, 2022
6cdf575
Add partial filtering and evaluation
Emyrk Aug 10, 2022
f5eacd0
Benmark Partials
Emyrk Aug 10, 2022
4a7c68e
Linting
Emyrk Aug 10, 2022
df75be5
Spelling
Emyrk Aug 10, 2022
e90ac2d
Fix recording fake authorizer
Emyrk Aug 10, 2022
1e774e0
Fix partial query tests
Emyrk Aug 10, 2022
38917dc
Working partial execution to queries
Emyrk Aug 10, 2022
e139a1f
Cleanup
Emyrk Aug 10, 2022
c44d4d1
Cleanup
Emyrk Aug 10, 2022
19f3557
Add comments
Emyrk Aug 10, 2022
f9dd9aa
Spelling
Emyrk Aug 10, 2022
bed9f4f
Remove old Filter
Emyrk Aug 10, 2022
74d90f4
Improve error message
Emyrk Aug 10, 2022
fe0d05a
Comments
Emyrk Aug 10, 2022
dd5c55c
Make test parallel
Emyrk Aug 10, 2022
ae22f89
Fix typo
Emyrk Aug 10, 2022
0266963
Drop an arg from Filter
Emyrk Aug 10, 2022
af457b9
Test timed out
Emyrk Aug 10, 2022
21f4f21
Test less random, rename param
Emyrk Aug 11, 2022
2c87220
Add rego comments with explainations
Emyrk Aug 11, 2022
1c407ab
Add more rego comments
Emyrk Aug 11, 2022
9f9b2d1
Move fakeauthorizer code
Emyrk Aug 11, 2022
ab55cf5
Unexport partial fields
Emyrk Aug 11, 2022
abf098d
Reduce wait
Emyrk Aug 11, 2022
44c7370
Linting + Typos
Emyrk Aug 11, 2022
4611322
Wording
Emyrk Aug 11, 2022
c8e26a8
Test runs long
Emyrk Aug 11, 2022
510e94b
The single test is taking too long
Emyrk Aug 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Spelling
  • Loading branch information
@Emyrk
Emyrk committed Aug 10, 2022
commit df75be5ebf08ffb9e8d3db49c65d5eaa4b98dd02
4 changes: 2 additions & 2 deletions coderd/rbac/authz_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,10 +613,10 @@ func testAuthorize(t *testing.T, name string, subject subject, sets ...[]authTes
}
require.Equal(t, 0, len(result.Support), "expected 0 support rules")

partialAuther, err := authorizer.Prepare(ctx, subject.UserID, subject.Roles, a, c.resource.Type)
partialAuthz, err := authorizer.Prepare(ctx, subject.UserID, subject.Roles, a, c.resource.Type)
require.NoError(t, err, "make prepared authorizer")

partialErr := partialAuther.Authorize(ctx, c.resource)
partialErr := partialAuthz.Authorize(ctx, c.resource)
if authError != nil {
require.Error(t, partialErr, "partial error blocked valid request (false negative)")
} else {
Expand Down
2 changes: 0 additions & 2 deletions coderd/rbac/policy.rego
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ number(set) = c {

default site = 0
site := num {
# relevent are all the permissions that affect the given unknown object
allow := { x |
perm := input.subject.roles[_].site[_]
perm.action in [input.action, "*"]
Expand Down Expand Up @@ -81,7 +80,6 @@ org_mem := true {
default user = 0
user := num {
input.subject.id = input.object.owner
# relevent are all the permissions that affect the given unknown object
allow := { x |
perm := input.subject.roles[_].user[_]
perm.action in [input.action, "*"]
Expand Down