fix: Add SIGHUP and SIGTERM handling to coder server
#3543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To prevent additional signals from aborting program execution, signal handling was moved to the beginning of the main function, this ensures that signals stays registered for the entire shutdown procedure. Fixes #1529
johnstcn
approved these changes
Aug 18, 2022
mafredri
commented
Aug 18, 2022
| // | ||
| // To get out of a graceful shutdown, the user can send | ||
| // SIGQUIT with ctrl+\ or SIGKILL with `kill -9`. | ||
| notifyCtx, notifyStop := signal.NotifyContext(ctx, interruptSignals...) |
There was a problem hiding this comment.
Note: Naming this notifyCtx here means that during startup, and interrupt signal won't abort the process up until we start listening <-notifyCtx.Done().
The reason for this is that we have certain services that begin their shutdown procedure on context cancellation, but we want to control the order in which things are shut down.
I think it's acceptable that after starting, ctrl+c won't close coder server until the initial startup sequence is complete. But it's possible to work around this by monitoring the notifyCtx separately for parts of the startup where we want an early exit.
johnstcn
approved these changes
Aug 18, 2022
kylecarbs
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent additional signals from aborting program execution, signal
handling was moved to the beginning of the main function, this ensures
that signals stays registered for the entire shutdown procedure.
Fixes #1529