feat: Add template settings page #3557
Conversation
site/src/xServices/templateSettings/templateSettingsXService.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
I think the full-page modal design will bite us in the relatively short-term future. When we add more options, the page will only get longer and eventually have to be recreated (probably even if we added 4-5 more).
I like the hierarchy of design here from Vercel. It displays the resource being edited (in this case our coder.com deployment) and has a scalable design for adding more options. The design in this PR is functional for now but doesn't have the professional polish I think would be nice. That is nice to have though, so I certainly won't block this change!
(I don't have time to do a code review right now, I just watched the demo, so someone else should review!)
Yes, it is because you have to click outside the form... Idk why this happens, but it looks like MUI doesn't display the error if it is focused - the input is auto-focus. Not sure if I should add some auto-focus logic to enable it only when the form doesn't have errors... sounds too much. What do you think @presleyp ? |
Co-authored-by: Presley Pizzo <1290996+presleyp@users.noreply.github.com>
|
@kylecarbs I agree with you. I just would expect we have more options because a page like the Vercel one, only looks good if you have options enough to fill the space. |
|
@presleyp I find out I can use |
Related to #2221
Demo:
Screen.Recording.2022-08-18.at.14.40.46.mov