web: use seconds in max TTL input #3576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b7fcf03 to
92cf9a1
Compare
|
@BrunoQuaresma, I'm pretty new to TS and our frontend codebase. If I did anything in a suboptimal way, please let me know. |
Milliseconds are more difficult to deal with due to all of the zeros. Also, describe this feature as "auto-stop" to be consistent with our Workspace page UI and CLI. "ttl" is our backend lingo which should eventually be updated.
|
I think we could do better, and set this as minutes, what do you think? |
|
@ammario I made the conversion in the handlers, so we don't have to add extra logic to map BE errors to a diff field, and vice-versa. |
|
@BrunoQuaresma — makes sense. Thanks for showing me how this is done. Plz approve and then it can merge. |
johnstcn
approved these changes
Aug 22, 2022
jsjoeio
approved these changes
Aug 22, 2022
I agree. Ideally the frontend accepts the same input as the CLI so there's so no truncation. I thought this PR was a step forward but not ideal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Milliseconds are more difficult to deal with due to
all of the zeros.