Skip to content

cli: remove confirm prompt when starting a workspace #3580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

johnstcn
Copy link
Member

This PR removes the CLI confirmation prompt when starting a workspace.
I find it annoying to have to confirm this for a start operation. For stop / delete operations, it makes more sense.

@johnstcn johnstcn requested a review from a team August 19, 2022 09:20
@johnstcn johnstcn self-assigned this Aug 19, 2022
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I agree it’s not useful and never what I expect. I’d argue the same for stop too but maybe we keep it to this one change for now 😄

@johnstcn johnstcn merged commit 57f3410 into main Aug 19, 2022
@johnstcn johnstcn deleted the cj/remove-start-confirm branch August 19, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants