Skip to content

chore: k8s example persistence & coder images #3619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 24, 2022
Merged

chore: k8s example persistence & coder images #3619

merged 4 commits into from
Aug 24, 2022

Conversation

ericpaulsen
Copy link
Member

@ericpaulsen ericpaulsen commented Aug 22, 2022 •
edited
Loading

this PR looks to address @ammario's feedback in #3588 by adding persistence to our k8s example template.

it also removes the VS Code dev container images in favor of Coder's enterprise images. The dev container images used /home/vscode, which contained shell scripts/customizations that would be wiped with a /home/vscode volume mount.

open to thoughts/feedback on removing the dev container images.

@ericpaulsen ericpaulsen self-assigned this Aug 22, 2022
ammario
ammario approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@ammario ammario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for knocking this out. I didn't test it, but I assume you did. Feel free to merge if that's the case.

@ammario
Copy link
Member

ammario commented Aug 22, 2022

And, I do think it's odd how there are multiple containers. That seems like a niche use case.

@ericpaulsen
Copy link
Member Author

And, I do think it's odd how there are multiple containers. That seems like a niche use case.

i agree - i originally considered reducing it to one container. i'll push commit reflecting this, and also include code-server in the template (something we should do for all of our examples).

@bpmct
Copy link
Member

bpmct commented Aug 22, 2022 •
edited
Loading

And, I do think it's odd how there are multiple containers. That seems like a niche use case.

This template is called kubernetes-multi-service so we'll need to change the name to reflect that it's no longer highlighting that use case.

I also noticed disk size & controls was removed. Was this to prevent breaking changes?

nvm

@ericpaulsen ericpaulsen merged commit ca3c049 into main Aug 24, 2022
@ericpaulsen ericpaulsen deleted the k8s-template-pvc branch August 24, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ammario ammario ammario approved these changes

@sharkymark sharkymark Awaiting requested review from sharkymark

@bpmct bpmct Awaiting requested review from bpmct

Assignees

@ericpaulsen ericpaulsen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ericpaulsen @ammario @bpmct @sharkymark