Skip to content

chore: bump golangci/golangci-lint-action from 2 to 3 #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 25, 2022

Bumps golangci/golangci-lint-action from 2 to 3.

Release notes

Sourced from golangci/golangci-lint-action's releases.

v3.0.0

What's Changed

New Contributors

Full Changelog: golangci/golangci-lint-action@v2...v3.0.0

Bump version v2.5.2

Bug fixes

  • 5c56cd6 Extract and don't mangle User Args. (#200)

Dependencies

  • e3c53fe bump @​typescript-eslint/eslint-plugin (#194)
  • 3b9f80e bump @​typescript-eslint/parser from 4.18.0 to 4.19.0 (#195)
  • 9845713 bump @​types/node from 14.14.35 to 14.14.37 (#197)
  • e789ee1 bump eslint from 7.22.0 to 7.23.0 (#196)
  • f2e9a96 bump @​typescript-eslint/eslint-plugin (#188)
  • 818081a bump @​types/node from 14.14.34 to 14.14.35 (#189)
  • 6671836 bump @​typescript-eslint/parser from 4.17.0 to 4.18.0 (#190)
  • 526907e bump @​typescript-eslint/parser from 4.16.1 to 4.17.0 (#185)
  • 6b6ba16 bump @​typescript-eslint/eslint-plugin (#186)
  • 9cab4ef bump eslint from 7.21.0 to 7.22.0 (#187)
  • 0c76572 bump @​types/node from 14.14.32 to 14.14.34 (#184)
  • 0dfde21 bump @​typescript-eslint/parser from 4.15.2 to 4.16.1 (#182)
  • 9dcf389 bump typescript from 4.2.2 to 4.2.3 (#181)
  • 34d3904 bump @​types/node from 14.14.31 to 14.14.32 (#180)
  • e30b22f bump @​typescript-eslint/eslint-plugin (#179)
  • 8f30d25 bump eslint from 7.20.0 to 7.21.0 (#177)
  • 0b64a40 bump @​typescript-eslint/parser from 4.15.1 to 4.15.2 (#176)
  • 973b3a3 bump eslint-config-prettier from 8.0.0 to 8.1.0 (#178)
  • 6ea3de1 bump @​typescript-eslint/eslint-plugin (#175)
  • 6eec6af bump typescript from 4.1.5 to 4.2.2 (#174)

v2.5.1

Bug fixes:

  • d9f0e73 Check that go.mod exists in reading the version (#173)

v2.5.0

New Features:

... (truncated)

Commits
  • c675eb7 Update all direct dependencies (#404)
  • 423fbaf Remove Setup-Go (#403)
  • bcfc6f9 build(deps-dev): bump eslint-plugin-import from 2.25.3 to 2.25.4 (#402)
  • d34ac2a build(deps): bump setup-go from v2.1.4 to v2.2.0 (#401)
  • e4b538e build(deps-dev): bump @​types/node from 16.11.10 to 17.0.19 (#400)
  • a288c0d build(deps): bump @​actions/cache from 1.0.8 to 1.0.9 (#399)
  • b7a34f8 build(deps): bump @​types/tmp from 0.2.2 to 0.2.3 (#398)
  • 129bcf9 build(deps-dev): bump @​types/uuid from 8.3.3 to 8.3.4 (#397)
  • 153576c build(deps-dev): bump eslint-config-prettier from 8.3.0 to 8.4.0 (#396)
  • a9a9dff build(deps): bump ansi-regex from 5.0.0 to 5.0.1 (#395)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 2 to 3.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases)
- [Commits](golangci/golangci-lint-action@v2...v3)

---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@bryphe-coder
Copy link
Contributor

Looks like this is picking up some new typecheck warnings: https://github.com/coder/coder/runs/5333502608?check_suite_focus=true#step:3:25

ie:

  Error: ReadFile not declared by package os (typecheck)
  Error: New not declared by package iofs (typecheck)
  Error: value.SourceValue undefined (type ComputedValue has no field or method SourceValue) (typecheck)
  Error: FS not declared by package http (typecheck)
  Error: ReadAll not declared by package io (typecheck)
  Error: Discard not declared by package io (typecheck)
  Error: UnixMilli not declared by package time (typecheck)
  Error: r.URL.Query().Has undefined (type url.Values has no field or method Has) (typecheck)
  Error: UnixMilli not declared by package time (typecheck)
  Error: UnixMilli not declared by package time (typecheck)
  Error: Discard not declared by package io (typecheck)
  Error: Discard not declared by package io (typecheck)
  Error: Discard not declared by package io (typecheck)
  Error: before.UTC().UnixMilli undefined (type time.Time has no field or method UnixMilli) (typecheck)
  Error: after.UTC().UnixMilli undefined (type time.Time has no field or method UnixMilli) (typecheck)
  Error: time.Now().UTC().UnixMilli undefined (type time.Time has no field or method UnixMilli) (typecheck)
  Error: time.Now().UTC().UnixMilli undefined (type time.Time has no field or method UnixMilli) (typecheck)
  Error: time.Now().UTC().UnixMilli undefined (type time.Time has no field or method UnixMilli) (typecheck)

@kylecarbs
Copy link
Member

Seems like this is using an old Go version 😕 All of these were added in Go 1.17

@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

Merging #363 (c8e3602) into main (41c3ee7) will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #363      +/-   ##
==========================================
- Coverage   67.55%   67.43%   -0.13%     
==========================================
  Files         148      148              
  Lines        8064     8064              
  Branches       72       72              
==========================================
- Hits         5448     5438      -10     
- Misses       2052     2059       +7     
- Partials      564      567       +3     
Flag Coverage Δ
unittest-go-macos-latest 65.98% <ø> (-0.17%) ⬇️
unittest-go-ubuntu-latest 67.17% <ø> (+0.14%) ⬆️
unittest-go-windows-2022 65.70% <ø> (ø)
unittest-js 66.10% <ø> (ø)
Impacted Files Coverage Δ
peerbroker/dial.go 76.19% <0.00%> (-4.77%) ⬇️
peer/conn.go 76.47% <0.00%> (-0.77%) ⬇️
coderd/provisionerdaemons.go 60.20% <0.00%> (-0.60%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41c3ee7...c8e3602. Read the comment docs.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 28, 2022

Superseded by #374.

@dependabot dependabot bot closed this Feb 28, 2022
@dependabot dependabot bot deleted the dependabot/github_actions/golangci/golangci-lint-action-3 branch February 28, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants