coder licenses add CLI command #3632
Conversation
Signed-off-by: Spike Curtis <spike@coder.com>
Signed-off-by: Spike Curtis <spike@coder.com>
Signed-off-by: Spike Curtis <spike@coder.com>
| func TestLicensesAddSuccess(t *testing.T) { | ||
| t.Parallel() | ||
| // We can't check a real license into the git repo, and can't patch out the keys from here, | ||
| // so instead we have to fake the HTTP interaction. |
There was a problem hiding this comment.
So that we can test licenses for real (in CI) should we consider adding a secret in GitHub actions and only test it in CI (or when defined locally?).
I'm not sure how it would work, just throwing it out there.
There was a problem hiding this comment.
Yeah, if we want to build e2e tests, we'll need real licenses that we don't check into the repo
|
|
||
| if filename != "" && license == "" { | ||
| var r io.Reader | ||
| if filename == "-" { |
There was a problem hiding this comment.
Suggestion (non-blocking): We could consider defaulting to using stdin when stdin is not a tty (and no --file or --license), this is a pretty common practice in cli programs.
There was a problem hiding this comment.
I picked up -f - from kubectl, FWIW
There was a problem hiding this comment.
Oh I didn’t mean to insinuate -f - needs to go away, it’s also very unix-y. My suggestion was something of an addition, but feel free to skip.
Signed-off-by: Spike Curtis <spike@coder.com>
There was a problem hiding this comment.
From our chat earlier today, I worry that by adding the license to the database we introduce a similar problem of consistency, versioning, and general stability in the product.
I think that this can easily be changed though, so I won't prevent this from merging. I'd like if the method to add a license was similar to HashiCorp's route... it seems really simple to me.
|
|
||
| func licenses() *cobra.Command { | ||
| cmd := &cobra.Command{ | ||
| Short: "Add, remove, and list licenses", |
There was a problem hiding this comment.
This description doesn't fit what this presently does, so if we did a release this might confuse people.
There was a problem hiding this comment.
That's true, but I am working on those, and the converse risk is forgetting to update this
Fixes #3279
Adds a new
coder licenses addsubcommand.