Skip to content

fix: disable AccountForm when user is not allowed edit users #3649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 23, 2022
Merged

fix: disable AccountForm when user is not allowed edit users #3649

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
15f7d35
RED: add unit tests for AccountForm username field
johnstcn Aug 23, 2022
8772cf0
hopefully make the test green
johnstcn Aug 23, 2022
bbce1af
remove unnecesary tests
johnstcn Aug 23, 2022
1800982
move things to the right place
johnstcn Aug 23, 2022
8e8b4ec
PR comment
johnstcn Aug 23, 2022
a8ad515
ensure button is also not enabled
johnstcn Aug 23, 2022
73fc790
🤯
johnstcn Aug 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
🤯
  • Loading branch information
@johnstcn
johnstcn committed Aug 23, 2022
commit 73fc7909cc9600153f8cafcb0ba25e0b5a9ea209
4 changes: 2 additions & 2 deletions site/src/components/SettingsAccountForm/SettingsAccountForm.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ describe("AccountForm", () => {
// Then
const el = await screen.findByLabelText("Username")
expect(el).toBeEnabled()
const btn = await screen.findByRole("button")
const btn = await screen.findByRole("button", { name: /Update settings/i })
expect(btn).toBeEnabled()
})
})
Expand Down Expand Up @@ -58,7 +58,7 @@ describe("AccountForm", () => {
// Then
const el = await screen.findByLabelText("Username")
expect(el).toBeDisabled()
const btn = await screen.findByRole("button")
const btn = await screen.findByRole("button", { name: /Update settings/i })
expect(btn).toBeDisabled()
})
})
Expand Down