Skip to content

Enterprise rbac testing #3653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 24, 2022
Merged

Enterprise rbac testing #3653

merged 3 commits into from
Aug 24, 2022

Conversation

spikecurtis
Copy link
Contributor

Enterprise API routes were not being covered by our TestAuthorizeAllEndpoints test. This refactors the test to move most of the logic into coderdtest so it can be reused by enterprise code, and adds a test for the new license API.

Signed-off-by: Spike Curtis <spike@coder.com>
Signed-off-by: Spike Curtis <spike@coder.com>
@spikecurtis spikecurtis requested review from Emyrk and kylecarbs August 23, 2022 23:47
Signed-off-by: Spike Curtis <spike@coder.com>
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat abstraction. Pretty simple, and cool that this is tested in both spots 😎

@spikecurtis spikecurtis merged commit 9e35793 into main Aug 24, 2022
@spikecurtis spikecurtis deleted the spike/enterprise_rbac_testing branch August 24, 2022 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants