Skip to content

fix: template: enforce bounds of template max_ttl #3662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 24, 2022
Merged

fix: template: enforce bounds of template max_ttl #3662

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e488e13
fix: enforce lower and upper limits on template max_ttl_ms
johnstcn Aug 24, 2022
c14aadd
add migration to enforce template max_ttl 7-day cap
johnstcn Aug 24, 2022
fc95dbe
allow setting template max_ttl to 0
johnstcn Aug 24, 2022
877e3d0
update template edit CLI help
johnstcn Aug 24, 2022
9f37134
fixup! allow setting template max_ttl to 0
johnstcn Aug 24, 2022
e834160
rm commented code
johnstcn Aug 24, 2022
2daa353
fixup! allow setting template max_ttl to 0
johnstcn Aug 24, 2022
b73c37c
fmt
johnstcn Aug 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update template edit CLI help
  • Loading branch information
@johnstcn
johnstcn committed Aug 24, 2022
commit 877e3d0949f035b435436c632350a7804fb45906
4 changes: 2 additions & 2 deletions cli/templateedit.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,8 @@ func templateEdit() *cobra.Command {
cmd.Flags().StringVarP(&name, "name", "", "", "Edit the template name")
cmd.Flags().StringVarP(&description, "description", "", "", "Edit the template description")
cmd.Flags().StringVarP(&icon, "icon", "", "", "Edit the template icon path")
cmd.Flags().DurationVarP(&maxTTL, "max-ttl", "", 0, "Edit the template maximum time before shutdown")
cmd.Flags().DurationVarP(&minAutostartInterval, "min-autostart-interval", "", 0, "Edit the template minimum autostart interval")
cmd.Flags().DurationVarP(&maxTTL, "max-ttl", "", 0, "Edit the template maximum time before shutdown - workspaces created from this template cannot stay running longer than this.")
cmd.Flags().DurationVarP(&minAutostartInterval, "min-autostart-interval", "", 0, "Edit the template minimum autostart interval - workspaces created from this template must wait at least this long between autostarts.")
cliui.AllowSkipPrompt(cmd)

return cmd
Expand Down