fix: Avoid double escaping of ProxyCommand on Windows #3664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylecarbs
approved these changes
Aug 24, 2022
mafredri
added a commit
that referenced
this pull request
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't have a Windows setup, but I tested this on Linux with the following:
Binary name:
SSH Config:
This shows that neither
\t, nor\nare interpreted as tab or newline, so\doesn't seem to have special meaning when inside"", but\"seems necessary to avoid it being interpreted as literal".Without
\"in the ProxyCommand, we get:zsh: unmatched ".I tried looking through OpenSSH documentation, but could not find specifics as to what happens inside
"", it simply mentions that""must be used when there is whitespace in the name.Fixes #2853