Skip to content

Template settings fixes/kira pilot #3668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Aug 24, 2022
Merged

Template settings fixes/kira pilot #3668

merged 13 commits into from
Aug 24, 2022

Conversation

Kira-Pilot
Copy link
Member

resolves #3640 from a FE perspective:

  • TTL is now displayed/entered in hours
  • TTL cannot be greater than 7 days (168 hours)
  • TTL has validation error if above condition is not met
  • TTL has helper text to add clarity
  • Description has max char count of 128
  • Description has validation error if above condition is not met
    Screen Shot 2022-08-24 at 10 34 48 AM

Screen Shot 2022-08-24 at 11 12 34 AM

@Kira-Pilot Kira-Pilot requested a review from a team as a code owner August 24, 2022 15:18
@Kira-Pilot Kira-Pilot requested review from jsjoeio and johnstcn and removed request for a team August 24, 2022 15:18
@Kira-Pilot @johnstcn
Update site/src/pages/TemplateSettingsPage/TemplateSettingsForm.tsx
1eda40c 
Co-authored-by: Cian Johnston <cian@coder.com>
johnstcn
johnstcn approved these changes Aug 24, 2022
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Backend ✅

jsjoeio
jsjoeio reviewed Aug 24, 2022
View reviewed changes
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🚀

@Kira-Pilot Kira-Pilot merged commit 57c202d into main Aug 24, 2022
@Kira-Pilot Kira-Pilot deleted the template-settings-fixes/kira-pilot branch August 24, 2022 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsjoeio jsjoeio jsjoeio left review comments

@johnstcn johnstcn johnstcn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: template settings
3 participants
@Kira-Pilot @jsjoeio @johnstcn