Skip to content

fix: Exclude time column when selecting build log #3673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 24, 2022
Merged

fix: Exclude time column when selecting build log #3673

merged 1 commit into from
Aug 24, 2022
+5 −1

Conversation

kylecarbs
Copy link
Member

Closes #2962.

@kylecarbs kylecarbs requested a review from a team as a code owner August 24, 2022 16:41
@kylecarbs kylecarbs self-assigned this Aug 24, 2022
@kylecarbs kylecarbs requested review from code-asher and removed request for a team August 24, 2022 16:41
jsjoeio
jsjoeio approved these changes Aug 24, 2022
View reviewed changes
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks harmless to me 👍🏼

@jsjoeio jsjoeio removed the request for review from code-asher August 24, 2022 17:00
@jsjoeio
Copy link
Contributor

jsjoeio commented Aug 24, 2022

Dismissing @code-asher's review since I reviewed already ✅

@kylecarbs kylecarbs merged commit 4f8270d into main Aug 24, 2022
@kylecarbs kylecarbs deleted the whitespacetime branch August 24, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsjoeio jsjoeio jsjoeio approved these changes

Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Selecting the build log should exclude time column
2 participants
@kylecarbs @jsjoeio