chore: update stale.yaml #3674
Merged
chore: update stale.yaml #3674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsjoeio
commented
Aug 24, 2022
.github/workflows/stale.yaml
Outdated
| @@ -20,7 +20,8 @@ jobs: | |||
| # Pull Requests become stale more quickly due to merge conflicts. | |||
| # Also, we promote minimizing WIP. | |||
| days-before-pr-stale: 7 | |||
| days-before-pr-close: 3 | |||
| days-before-issue-stale: 30 | |||
There was a problem hiding this comment.
Default value is 60 which feels too long if we want to keep issue count small. Is 30 too aggressive?
There was a problem hiding this comment.
I think 60 (or even 90) are better knobs based on my past experiences with stale bots. I worry that at 30 the stale bot spam will be more annoying than the issue count.
Based on pulse, the issue count has been shrinking naturally, so I don't think we should make this change.
There was a problem hiding this comment.
Good data to back that up. I will remove
jsjoeio
commented
Aug 24, 2022
jsjoeio
commented
Aug 24, 2022
.github/workflows/stale.yaml
Outdated
| @@ -20,7 +20,6 @@ jobs: | |||
| # Pull Requests become stale more quickly due to merge conflicts. | |||
| # Also, we promote minimizing WIP. | |||
| days-before-pr-stale: 7 | |||
| days-before-pr-close: 3 | |||
There was a problem hiding this comment.
That shouldn't have been deleted, one second
- remove close-issue-reason (only valid in 5.1.0) - add days-before-issue-stale 30
8cab6f3 to
4e5b6d2
Compare
kylecarbs
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes warning message https://github.com/coder/coder/actions/runs/2915593864