Skip to content

make agent 'connecting' visually different from 'connected' #3675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

f0ssel
Copy link
Contributor

@f0ssel f0ssel commented Aug 24, 2022

Since "Connected" status is green, I wanted to make "Connecting" distinct visually, so I used blue.

Before:
chrome_CEK7WnC6HD

After:
chrome_HrpSZOUXB4

Connected (for comparison):
image

@f0ssel f0ssel requested a review from a team as a code owner August 24, 2022 17:48
@f0ssel f0ssel requested review from BrunoQuaresma and removed request for a team August 24, 2022 17:48
@jsjoeio jsjoeio requested review from jsjoeio and removed request for BrunoQuaresma August 24, 2022 17:49
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me!

(reviewing in favor of @BrunoQuaresma who is on PTO)

@f0ssel f0ssel enabled auto-merge (squash) August 24, 2022 17:50
Copy link
Contributor

@presleyp presleyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bruno is out so I'll weigh in - I think the distinction is desirable and that blue/primary is a good choice.

@f0ssel f0ssel merged commit 4e3b212 into main Aug 24, 2022
@f0ssel f0ssel deleted the f0ssel/blue-connecting branch August 24, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants