Skip to content

fix: match term color #3694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 25, 2022
Merged

fix: match term color #3694

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
361f2d6
fix: match term color
f0ssel Aug 25, 2022
380bc1a
fmt:
f0ssel Aug 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: match term color
  • Loading branch information
@f0ssel
f0ssel committed Aug 25, 2022
commit 361f2d6e0a2a30d5c7770fa95e452162938f02fc
5 changes: 2 additions & 3 deletions site/src/pages/TerminalPage/TerminalPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import "xterm/css/xterm.css"
import { MONOSPACE_FONT_FAMILY } from "../../theme/constants"
import { pageTitle } from "../../util/page"
import { terminalMachine } from "../../xServices/terminal/terminalXService"
import { colors } from "theme/colors"

export const Language = {
workspaceErrorMessagePrefix: "Unable to fetch workspace: ",
Expand Down Expand Up @@ -75,9 +76,7 @@ const TerminalPage: FC<
fontFamily: MONOSPACE_FONT_FAMILY,
fontSize: 16,
theme: {
// This is a slight off-black.
// It's really easy on the eyes!
background: "#1F1F1F",
background: colors.gray[16],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine but palette.background.default is gray[15] so it might work as well. If the darker one looks better though, no problem.

},
rendererType: renderer,
})
Expand Down