Skip to content

Makefile buff-ification #3700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Sep 2, 2022
Merged

Makefile buff-ification #3700

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
73e4db4
chore: buff makefile pt. 1
deansheather Aug 26, 2022
8765bc4
chore: buff makefile pt. 2
deansheather Aug 26, 2022
e208509
chore: buff makefile pt. 3 docker
deansheather Aug 26, 2022
5a5cd1d
fixup! chore: buff makefile pt. 3 docker
deansheather Aug 26, 2022
29de6ce
chore: buff makefile pt. 4 make install
deansheather Aug 26, 2022
7a0f045
chore: buff makefile pt. 5 helm stuff
deansheather Aug 28, 2022
f866e1f
fixup! chore: buff makefile pt. 5 helm stuff
deansheather Aug 28, 2022
b81712b
fixup! chore: buff makefile pt. 5 helm stuff
deansheather Aug 29, 2022
c7317f4
chore: add makefile docs
deansheather Aug 29, 2022
317e80d
chore: fix release makefile stuff
deansheather Aug 29, 2022
ec1c10a
fixup! chore: fix release makefile stuff
deansheather Aug 29, 2022
a6f1b4c
chore: remove make bin target
deansheather Sep 1, 2022
6e4a441
Merge branch 'main' into buff-makefile
deansheather Sep 1, 2022
9cddd8a
Merge branch 'main' into buff-makefile
deansheather Sep 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! chore: buff makefile pt. 5 helm stuff
  • Loading branch information
@deansheather
deansheather committed Aug 28, 2022
commit f866e1fa64a865cc96e2d096620f79490ef6d081
27 changes: 13 additions & 14 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,16 +86,13 @@ jobs:
set -euxo pipefail

# build and (maybe) push Docker images for each architecture
images=()
for arch in amd64 armv7 arm64; do
img="$(
./scripts/build_docker.sh \
${{ (!github.event.inputs.dry_run && !github.event.inputs.snapshot) && '--push' || '' }} \
--arch "$arch" \
./build/coder_*_linux_"$arch"
)"
images+=("$img")
done
version="$(./script/version.sh)"
push=""
if [[ "$CODER_RELEASE" == *t* ]]; then
push="push/"
fi
make -j \
"$push"build/coder_"$version"_linux_{amd64,arm64,armv7}.tag

# we can't build multi-arch if the images aren't pushed, so quit now
# if dry-running
Expand All @@ -105,14 +102,13 @@ jobs:
fi

# build and push multi-arch manifest
./scripts/build_docker_multiarch.sh \
--push \
"${images[@]}"
make -j push/build/coder_"$version"_linux.tag

# if the current version is equal to the highest (according to semver)
# version in the repo, also create a multi-arch image as ":latest" and
# push it
if [[ "$(git tag | grep '^v' | grep -vE '(rc|dev|-|\+|\/)' | sort -r --version-sort | head -n1)" == "v$(./scripts/version.sh)" ]]; then
make -j push/build/coder_"$version"_linux.tag
./scripts/build_docker_multiarch.sh \
--push \
--target "$(./scripts/image_tag.sh --version latest)" \
Expand Down Expand Up @@ -252,7 +248,10 @@ jobs:
- name: Publish Helm
run: |
set -euxo pipefail
./scripts/helm.sh --push

version="$(./script/version.sh)"
make -j \
build/coder_helm_"$version".tgz
mv ./build/*.tgz ./artifacts/

- name: Publish Release
Expand Down