Skip to content

fix: mount TLS secret in helm chart #3717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 27, 2022
Merged

fix: mount TLS secret in helm chart #3717

merged 2 commits into from
Aug 27, 2022

Conversation

deansheather
Copy link
Member

@deansheather deansheather commented Aug 27, 2022 •
edited
Loading

Fixes TLS via coder.tls.secretName not working in helm chart. The env vars were being set but the secret was never mounted.

Tested, works with and without coder.tls.secretName set

@sharkymark sharkymark marked this pull request as ready for review August 27, 2022 11:42
@deansheather deansheather requested a review from coadler August 27, 2022 14:56
@deansheather deansheather enabled auto-merge (squash) August 27, 2022 14:58
@deansheather deansheather merged commit b9b9c2f into main Aug 27, 2022
@deansheather deansheather deleted the fix-helm-tls branch August 27, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@sharkymark sharkymark sharkymark approved these changes

@coadler coadler coadler approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deansheather @sharkymark @coadler