Skip to content

fix: Prevent autobuild executor from slowing down API requests #3726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 2, 2022
Merged

fix: Prevent autobuild executor from slowing down API requests #3726

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
11b7eb8
fix: Prevent autobuild executor from slowing down API requests
mafredri Aug 29, 2022
3a345aa
Add early return
mafredri Aug 29, 2022
45e4141
chore: Refactor autostart check, do it in Go
mafredri Aug 29, 2022
b4a650b
fix: Ensure deleted workspaces are not eligible
mafredri Aug 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: Ensure deleted workspaces are not eligible
  • Loading branch information
@mafredri
mafredri committed Sep 2, 2022
commit b4a650b370214df16236d66087d4b5ed7ea2e8da
2 changes: 1 addition & 1 deletion coderd/autobuild/executor/lifecycle_executor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ func (e *Executor) runOnce(t time.Time) Stats {
}

func isEligibleForAutoStartStop(ws database.Workspace) bool {
return ws.AutostartSchedule.String != "" || ws.Ttl.Int64 > 0
return !ws.Deleted && (ws.AutostartSchedule.String != "" || ws.Ttl.Int64 > 0)
}

func getNextTransition(
Expand Down