feat: Add destroy to workspace provision job #373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was detecting branches, but not our "main" branch before. Hopefully this fixes it!
This enables a consistent API for project import and provisioned resources.
This is a much cleaner abstraction. Explicitly declaring the user parameters for each provisioner makes for significantly simpler testing.
Terraform (or other provisioners) may need to cleanup state, or cancel actions before exit. This adds the ability to gracefully exit provisionerd.
This enables the full flow of create/update/delete.
Codecov Report
@@ Coverage Diff @@
## main #373 +/- ##
==========================================
+ Coverage 67.24% 67.70% +0.46%
==========================================
Files 148 150 +2
Lines 8271 8454 +183
Branches 72 72
==========================================
+ Hits 5562 5724 +162
- Misses 2132 2150 +18
- Partials 577 580 +3
Continue to review full report at Codecov.
|
Comment on lines
+452
to
+454
| if transition == proto.WorkspaceTransition_DESTROY { | ||
| args = append(args, "-destroy") | ||
| } |
There was a problem hiding this comment.
I didn't know this flag was available - I thought it needed terraform destroy - TIL. This flag is certainly cleaner 👍
bryphe-coder
approved these changes
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the full flow of create/update/delete.