fix: Templates table columns width #3731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylecarbs
approved these changes
Aug 29, 2022
presleyp
reviewed
Aug 29, 2022
| <TableCell>{Language.lastUpdatedLabel}</TableCell> | ||
| <TableCell>{Language.createdByLabel}</TableCell> | ||
| <TableCell width="50%">{Language.nameLabel}</TableCell> | ||
| <TableCell width="16%">{Language.usedByLabel}</TableCell> |
There was a problem hiding this comment.
It looks great, but I wonder if there's a better way than hard-coding a percentage.
There was a problem hiding this comment.
I've always used hard-coded widths with percentages when working with tables but it is true this doesn't look good. Any suggestions?
There was a problem hiding this comment.
The MUI docs didn't give me any good ideas (you can set a cell to "small" but the problem was they were too small, even though the default is "medium", so that wouldn't help), so I think this is fine as long as it looks good in different screen sizes!
presleyp
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3639
Before fix:
After fix:
