Skip to content

fix: Use "data" scheme when creating parameters from the site #3732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 29, 2022
Merged

fix: Use "data" scheme when creating parameters from the site #3732

merged 1 commit into from
Aug 29, 2022

Conversation

kylecarbs
Copy link
Member

Fixes #3691.

@kylecarbs kylecarbs self-assigned this Aug 29, 2022
@kylecarbs kylecarbs requested a review from a team as a code owner August 29, 2022 16:21
mafredri
mafredri approved these changes Aug 29, 2022
View reviewed changes
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏻

@kylecarbs kylecarbs enabled auto-merge (squash) August 29, 2022 16:28
@kylecarbs kylecarbs merged commit 611ca55 into main Aug 29, 2022
@kylecarbs kylecarbs deleted the defaultscheme branch August 29, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mafredri mafredri mafredri approved these changes

@jsjoeio jsjoeio jsjoeio approved these changes

@BrunoQuaresma BrunoQuaresma Awaiting requested review from BrunoQuaresma

Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@kylecarbs @mafredri @jsjoeio