refactor: Redesign auth cli page and add workspaces link #3737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrunoQuaresma
commented
Aug 29, 2022
| textAlign: "center", | ||
| flex: "0", | ||
| paddingTop: theme.spacing(2), | ||
| paddingBottom: theme.spacing(2), | ||
| marginTop: theme.spacing(3), | ||
| marginTop: theme.spacing(8), |
There was a problem hiding this comment.
The footer was to close to the form.
BrunoQuaresma
commented
Aug 29, 2022
| @@ -55,12 +56,12 @@ export const Footer: React.FC<React.PropsWithChildren<FooterProps>> = ({ buildIn | |||
|
|
|||
| const useFooterStyles = makeStyles((theme) => ({ | |||
| root: { | |||
| opacity: 0.6, | |||
| color: colors.gray[7], | |||
There was a problem hiding this comment.
I tried the palette.text.secondary but for this background and how "soft" we want the color I decided to use the color directly since it is very specific to this component.
BrunoQuaresma
commented
Aug 29, 2022
| import * as TypesGen from "../../api/typesGenerated" | ||
|
|
||
| export const Language = { | ||
| buildInfoText: (buildInfo: TypesGen.BuildInfoResponse): string => { | ||
| return `Coder ${buildInfo.version}` | ||
| }, | ||
| copyrightText: `Copyright \u00a9 ${new Date().getFullYear()} Coder Technologies, Inc. All rights reserved.`, | ||
| copyrightText: `Copyright \u00a9 ${new Date().getFullYear()} Coder Technologies, Inc.`, |
There was a problem hiding this comment.
I removed the "All rights reserved." so the footer width doesn't look bigger than the main container - it looks weird IMO - and also, it is "redundant" since Copyright is about "rights reserved" I guess.
coadler
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
Closes #3678