Skip to content

refactor(scripts): use ln -P on non-darwin arch #3740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 29, 2022
Merged

refactor(scripts): use ln -P on non-darwin arch #3740

merged 1 commit into from
Aug 29, 2022

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Aug 29, 2022 •
edited
Loading

Fixes #2738

@jsjoeio jsjoeio self-assigned this Aug 29, 2022
@jsjoeio jsjoeio added the chore label Aug 29, 2022
@jsjoeio jsjoeio marked this pull request as ready for review August 29, 2022 20:16
deansheather
deansheather reviewed Aug 29, 2022
View reviewed changes
Copy link
Member

@deansheather deansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually don't think we need the -P at all on either platform. Could you just remove the -P entirely instead?

@jsjoeio jsjoeio requested a review from deansheather August 29, 2022 20:23
deansheather
deansheather approved these changes Aug 29, 2022
View reviewed changes
Copy link
Member

@deansheather deansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if they still work on linux and darwin 👍

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Aug 29, 2022

if they still work on linux and darwin 👍

Now I'm doubting myself 😂 Let me run make build and check.

@jsjoeio jsjoeio marked this pull request as draft August 29, 2022 20:27
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Aug 29, 2022

Looks good to me 👍🏼

@jsjoeio jsjoeio marked this pull request as ready for review August 29, 2022 22:05
@jsjoeio jsjoeio merged commit 05f932b into main Aug 29, 2022
@jsjoeio jsjoeio deleted the jsjoeio/fix-ln branch August 29, 2022 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deansheather deansheather deansheather approved these changes

@mafredri mafredri Awaiting requested review from mafredri

Assignees

@jsjoeio jsjoeio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warn user's when running make build locally
2 participants
@jsjoeio @deansheather