-
Notifications
You must be signed in to change notification settings - Fork 887
chore: rearrange audit logging code into enterprise folder #3741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
type Auditor interface { | ||
Export(ctx context.Context, alog database.AuditLog) error | ||
diff(old, new any) Map | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One missing item is the "noop" implementation of the interface
What could be good mock values? I was able to get these:
|
Does this work?
|
That is great, thanks @coadler |
The attribute name is the key in the diff map! |
Ahh I see so it is something like:
Is that right? |
yep! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FE looks good to me
Rearranges the auditing code to fit into the new RFC.